Add TagBot.yml #69
Merged
Add TagBot.yml #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 83.85% 83.85%
=======================================
Files 7 7
Lines 353 353
=======================================
Hits 296 296
Misses 57 57 ☔ View full report in Codecov by Sentry. |
|
Thanks again, @JoshuaLampert! |
|
@JoshuaLampert What actions are supposed to trigger TagBot to generate a tag and Release? I was thinking it would detect a version bump in the |
|
You still need to call the JuliaRegistrator by commenting on the last commit, which bumped the package version as you did before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there is no tag bot used, i.e. you manually create a tag after registering a new version of the package. The tag bot is widely used for Julia packages to automatically create a new tag once the register PR in General is merged. This way consistency between the registry in General and the actual registered versions is guaranteed and you don't need to manually create a new tag. I think it's generally considered good practice to have tag bot running and thus it would be nice to also have it here.
See https://github.com/JuliaRegistries/TagBot.